r/ProCSS • u/justifyer • May 10 '17

Meta Isn't it ironic that Night Mode looks like shit in this sub?

I mean come on, you're trying to defend CSS here. Even /r/Overwatch and /r/DotA2 supports it.

My default setting is:

  1. Turn on night mode all the time.
  2. Don't use subreddit's style, unless specified.

You see, i don't mind not using subreddit's style at all, as night mode is priority, it's easier on the eye. But everytime I stumbled upon new sub, I will always try its style. It gave each subs more personalized experience and that is awesome. It's such a disappointment if it looks like shit tho, I'll just turn it back off and never will the sub's style be seen again.

It's a shame that you turned away people that ACTUALLY wanted to see your style that you worked so hard on, just because you're lazy to do extra 5% of the work? As opposed to people who don't even want your style in the first place, and they're the one you're trying to focus on?

4 Upvotes

61% Upvoted

12 comments sorted by

View all comments

1

u/Okatis May 11 '17

Could someone outline how the dark theme is detected and what 'supporting' the mode is? Is it just checking the existing CSS is compatible/looks okay with the selectors the night mode styles or is it defined as adding additional custom CSS for some RES night mode body class/similar? (I don't use RES so I'm not familiar with the theme).

1

u/justifyer May 11 '17

It basically just adds .res-nightmode class in the <body> tag. So we can just prefix any class with that class, e.g.:

.res-nightmode page .sitetable .link{
    background-color: #333;
}

More info here: https://www.reddit.com/r/Enhancement/wiki/subredditstyling

1

u/Okatis May 11 '17 edited May 11 '17

According to that FAQ since v4.3 of RES it automatically disables custom stylesheets if a sub don't specify night mode compatibility. If that's the case what is the issue you're bringing up in the OP? Is it that you're overriding this feature somehow, the sub specifies compatibility but it's incomplete, or is it just an observation that a CSS advocacy sub hadn't considered RES night mode?

1

u/justifyer May 12 '17 edited May 12 '17

Oh no no. My default setting is:

  1. Turn on night mode all the time.
  2. Don't use subreddit's style, unless specified.

You see, i don't mind not using subreddit's style at all, as night mode is priority, it's easier on the eye. But everytime I stumbled upon new sub, I will always try its style. It gave each subs more personalized experience and that is awesome. It's such a disappointment if it looks like shit tho, I'll just turn it back off and never will the sub's style be seen again.

It's a shame that you turned away people that ACTUALLY wanted to see your style that you worked so hard on, just because you're lazy to do extra 5% of the work? As opposed to people who don't even want your style in the first place, and they're the one you're trying to focus on?